github/datasette
1
0
Fork 0
mirror of https://github.com/simonw/datasette.git synced 2025-12-10 16:51:24 +01:00
Code Issues Projects Releases Packages Wiki Activity

Preserve query string in % to - redirects, refs #1650

Browse source
This commit is contained in:
Simon Willison 2022-03-07 08:18:07 -08:00
commit 020effe47b
2 changed files with 16 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

17
tests/test_html.py
View file

@ -954,7 +954,18 @@ def test_no_alternate_url_json(app_client, path):
)
def test_redirect_percent_encoding_to_dash_encoding(app_client):
response = app_client.get("/fivethirtyeight/twitter-ratio%2Fsenators")
@pytest.mark.parametrize(
"path,expected",
(
(
"/fivethirtyeight/twitter-ratio%2Fsenators",
"/fivethirtyeight/twitter-2Dratio-2Fsenators",
),
# query string should be preserved
("/foo/bar%2Fbaz?id=5", "/foo/bar-2Fbaz?id=5"),
),
)
def test_redirect_percent_encoding_to_dash_encoding(app_client, path, expected):
response = app_client.get(path)
assert response.status == 302
assert response.headers["location"] == "/fivethirtyeight/twitter-2Dratio-2Fsenators"
assert response.headers["location"] == expected