github/datasette
1
0
Fork 0
mirror of https://github.com/simonw/datasette.git synced 2025-12-10 16:51:24 +01:00
Code Issues Projects Releases Packages Wiki Activity

Fix for incorrect hidden for fields for _columns, refs #1527

Browse source
This commit is contained in:
Simon Willison 2021-11-29 19:04:20 -08:00
commit 06762776f7
2 changed files with 18 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

13
tests/test_html.py
View file

@ -326,6 +326,19 @@ def test_existing_filter_redirects(app_client):
assert "?" not in response.headers["Location"]
def test_exact_parameter_results_in_correct_hidden_fields(app_client):
# https://github.com/simonw/datasette/issues/1527
response = app_client.get(
"/fixtures/facetable?_facet=_neighborhood&_neighborhood__exact=Downtown"
)
# In this case we should NOT have a hidden _neighborhood__exact=Downtown field
form = Soup(response.body, "html.parser").find("form")
hidden_inputs = {
input["name"]: input["value"] for input in form.select("input[type=hidden]")
}
assert hidden_inputs == {"_facet": "_neighborhood"}
def test_empty_search_parameter_gets_removed(app_client):
path_base = "/fixtures/simple_primary_key"
path = (