github/datasette
1
0
Fork 0
mirror of https://github.com/simonw/datasette.git synced 2025-12-10 16:51:24 +01:00
Code Issues Projects Releases Packages Wiki Activity

Fixed content-disposition header on DB download, closes #909

Browse source
This commit is contained in:
Simon Willison 2020-07-29 14:34:22 -07:00
commit 0748a65a22
4 changed files with 11 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
tests/test_csv.py
View file

@ -92,7 +92,7 @@ def test_table_csv_download(app_client):
assert response.status == 200
assert "text/csv; charset=utf-8" == response.headers["content-type"]
expected_disposition = 'attachment; filename="simple_primary_key.csv"'
assert expected_disposition == response.headers["Content-Disposition"]
assert expected_disposition == response.headers["content-disposition"]
def test_csv_with_non_ascii_characters(app_client):

5
tests/test_html.py
View file

@ -913,6 +913,11 @@ def test_database_download_for_immutable():
content_length = download_response.headers["content-length"]
assert content_length.isdigit()
assert int(content_length) > 100
assert "content-disposition" in download_response.headers
assert (
download_response.headers["content-disposition"]
== 'attachment; filename="fixtures.db"'
)
def test_database_download_disallowed_for_mutable(app_client):