github/datasette
1
0
Fork 0
mirror of https://github.com/simonw/datasette.git synced 2025-12-10 16:51:24 +01:00
Code Issues Projects Releases Packages Wiki Activity

Removed unneccessary isinstance(candidate, PermissionSQL)

Browse source
This commit is contained in:
Simon Willison 2025-10-23 15:48:48 -07:00
commit 092ada7b7d
2 changed files with 0 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

2
datasette/app.py
View file

@ -1090,8 +1090,6 @@ class Datasette:
for candidate in candidates: for candidate in candidates:
if candidate is None: if candidate is None:
continue continue
if not isinstance(candidate, PermissionSQL):
continue
plugin_blocks.append(candidate) plugin_blocks.append(candidate)
sql, params = build_rules_union( sql, params = build_rules_union(

6
datasette/views/special.py
View file

@ -305,12 +305,6 @@ class AllowedResourcesView(BaseView):
for candidate in candidates: for candidate in candidates:
if candidate is None: if candidate is None:
continue continue
if not isinstance(candidate, PermissionSQL):
logger.warning(
"Skipping permission_resources_sql result %r from plugin; expected PermissionSQL",
candidate,
)
continue
plugins.append(candidate) plugins.append(candidate)
rows = await resolve_permissions_from_catalog( rows = await resolve_permissions_from_catalog(