From 0a7621f96f8ad14da17e7172e8a7bce24ef78966 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Fri, 2 Apr 2021 20:42:28 -0700
Subject: [PATCH] Use pytest-xdist to speed up tests (#1290)

* Run tests in CI using pytest-xdist
* Documentation for pytest-xdist

Closes #1289
---
 .github/workflows/test.yml     |  3 ++-
 docs/contributing.rst          | 18 ++++++++++++++++++
 pytest.ini                     |  2 ++
 setup.py                       |  1 +
 tests/test_cli_serve_server.py |  3 +++
 5 files changed, 26 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index a1774213..bcb241d3 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -26,4 +26,5 @@ jobs:
         pip install -e '.[test]'
     - name: Run tests
       run: |
-        pytest
+        pytest -n auto -m "not serial"
+        pytest -m "serial"
diff --git a/docs/contributing.rst b/docs/contributing.rst
index 7e16280b..c3d0989a 100644
--- a/docs/contributing.rst
+++ b/docs/contributing.rst
@@ -43,10 +43,28 @@ The next step is to create a virtual environment for your project and use it to
 
 That last line does most of the work: ``pip install -e`` means "install this package in a way that allows me to edit the source code in place". The ``.[test]`` option means "use the setup.py in this directory and install the optional testing dependencies as well".
 
+.. _contributing_running_tests:
+
+Running the tests
+-----------------
+
 Once you have done this, you can run the Datasette unit tests from inside your ``datasette/`` directory using `pytest <https://docs.pytest.org/>`__ like so::
 
     pytest
 
+You can run the tests faster using multiple CPU cores with `pytest-xdist <https://pypi.org/project/pytest-xdist/>`__ like this::
+
+    pytest -n auto -m "not serial"
+
+``-n auto`` detects the number of available cores automatically. The ``-m "not serial"`` skips tests that don't work well in a parallel test environment. You can run those tests separately like so::
+
+    pytest -m "serial"
+
+.. _contributing_using_fixtures:
+
+Using fixtures
+--------------
+
 To run Datasette itself, type ``datasette``.
 
 You're going to need at least one SQLite database. A quick way to get started is to use the fixtures database that Datasette uses for its own tests.
diff --git a/pytest.ini b/pytest.ini
index aa292efc..d702ce5f 100644
--- a/pytest.ini
+++ b/pytest.ini
@@ -6,3 +6,5 @@ filterwarnings=
     ignore:Using or importing the ABCs::bs4.element
     # Python 3.7 PendingDeprecationWarning: Task.current_task()
     ignore:.*current_task.*:PendingDeprecationWarning
+markers =
+    serial: tests to avoid using with pytest-xdist
diff --git a/setup.py b/setup.py
index 3540e30a..c67aa6a3 100644
--- a/setup.py
+++ b/setup.py
@@ -70,6 +70,7 @@ setup(
         "docs": ["sphinx_rtd_theme", "sphinx-autobuild"],
         "test": [
             "pytest>=5.2.2,<6.3.0",
+            "pytest-xdist>=2.2.1,<2.3",
             "pytest-asyncio>=0.10,<0.15",
             "beautifulsoup4>=4.8.1,<4.10.0",
             "black==20.8b1",
diff --git a/tests/test_cli_serve_server.py b/tests/test_cli_serve_server.py
index 6962d2fd..6f5366d1 100644
--- a/tests/test_cli_serve_server.py
+++ b/tests/test_cli_serve_server.py
@@ -1,6 +1,8 @@
 import httpx
+import pytest
 
 
+@pytest.mark.serial
 def test_serve_localhost_http(ds_localhost_http_server):
     response = httpx.get("http://localhost:8041/_memory.json")
     assert {
@@ -10,6 +12,7 @@ def test_serve_localhost_http(ds_localhost_http_server):
     }.items() <= response.json().items()
 
 
+@pytest.mark.serial
 def test_serve_localhost_https(ds_localhost_https_server):
     _, client_cert = ds_localhost_https_server
     response = httpx.get("https://localhost:8042/_memory.json", verify=client_cert)