github/datasette
1
0
Fork 0
mirror of https://github.com/simonw/datasette.git synced 2025-12-10 16:51:24 +01:00
Code Issues Projects Releases Packages Wiki Activity

Compound primary key support for /db/-/create - closes #1911

Browse source 
Needed for tests in #1864
This commit is contained in:
Simon Willison 2022-11-29 10:47:46 -08:00
commit 1154048f79
3 changed files with 69 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

16
datasette/views/database.py
View file

@ -701,7 +701,7 @@ async def _table_columns(datasette, database_name):
class TableCreateView(BaseView):
name = "table-create"
_valid_keys = {"table", "rows", "row", "columns", "pk"}
_valid_keys = {"table", "rows", "row", "columns", "pk", "pks"}
_supported_column_types = {
"text",
"integer",
@ -785,18 +785,28 @@ class TableCreateView(BaseView):
return _error(["rows must be a list of objects"])
pk = data.get("pk")
pks = data.get("pks")
if pk and pks:
return _error(["Cannot specify both pk and pks"])
if pk:
if not isinstance(pk, str):
return _error(["pk must be a string"])
if pks:
if not isinstance(pks, list):
return _error(["pks must be a list"])
for pk in pks:
if not isinstance(pk, str):
return _error(["pks must be a list of strings"])
def create_table(conn):
table = sqlite_utils.Database(conn)[table_name]
if rows:
table.insert_all(rows, pk=pk)
table.insert_all(rows, pk=pks or pk)
else:
table.create(
{c["name"]: c["type"] for c in columns},
pk=pk,
pk=pks or pk,
)
return table.schema