From 141544613f9e76ddb74eee38d6f8ee1e0e70f833 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Wed, 30 Sep 2020 16:55:00 -0700
Subject: [PATCH] Extract out menu icon CSS, refs #981

---
 datasette/static/app.css  | 7 +++++++
 datasette/static/table.js | 5 +----
 2 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/datasette/static/app.css b/datasette/static/app.css
index 206ef561..4b43a9f0 100644
--- a/datasette/static/app.css
+++ b/datasette/static/app.css
@@ -388,6 +388,13 @@ button.button-as-link {
     font-size: 1em;
 }
 
+svg.dropdown-menu-icon {
+    display: inline-block;
+    position: relative;
+    top: 2px;
+    cursor: pointer;
+    opacity: 0.8;
+}
 .dropdown-menu {
     display: inline-flex;
     border: 1px solid #ccc;
diff --git a/datasette/static/table.js b/datasette/static/table.js
index db201ecc..9dd007f3 100644
--- a/datasette/static/table.js
+++ b/datasette/static/table.js
@@ -117,9 +117,7 @@ var DROPDOWN_ICON_SVG = `<svg xmlns="http://www.w3.org/2000/svg" width="14" heig
     var svg = document.createElement('div');
     svg.innerHTML = DROPDOWN_ICON_SVG;
     svg = svg.querySelector('*');
-    svg.style.display = 'inline-block';
-    svg.style.position = 'relative';
-    svg.style.top = '1px';
+    svg.classList.add('dropdown-menu-icon');
     var menu = document.createElement('div');
     menu.innerHTML = DROPDOWN_HTML;
     menu = menu.querySelector('*');
@@ -134,7 +132,6 @@ var DROPDOWN_ICON_SVG = `<svg xmlns="http://www.w3.org/2000/svg" width="14" heig
         }
         var icon = svg.cloneNode(true);
         icon.addEventListener('click', iconClicked);
-        icon.style.cursor = 'pointer';
         th.appendChild(icon);
     });
 })();