github/datasette
1
0
Fork 0
mirror of https://github.com/simonw/datasette.git synced 2025-12-10 16:51:24 +01:00
Code Issues Projects Releases Packages Wiki Activity

Removed check_permission() from BaseView, closes #1677

Browse source 
Refs #1660
This commit is contained in:
Simon Willison 2022-03-21 11:41:56 -07:00
commit 194e4f6c3f
6 changed files with 16 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

13
tests/test_permissions.py
View file

@ -321,17 +321,20 @@ def test_permissions_debug(app_client):
checks = [
{
"action": div.select_one(".check-action").text,
"result": bool(div.select(".check-result-true")),
# True = green tick, False = red cross, None = gray None
"result": None
if div.select(".check-result-no-opinion")
else bool(div.select(".check-result-true")),
"used_default": bool(div.select(".check-used-default")),
}
for div in check_divs
]
assert [
assert checks == [
{"action": "permissions-debug", "result": True, "used_default": False},
{"action": "view-instance", "result": True, "used_default": True},
{"action": "view-instance", "result": None, "used_default": True},
{"action": "permissions-debug", "result": False, "used_default": True},
{"action": "view-instance", "result": True, "used_default": True},
] == checks
{"action": "view-instance", "result": None, "used_default": True},
]
@pytest.mark.parametrize(