github/datasette
1
0
Fork 0
mirror of https://github.com/simonw/datasette.git synced 2025-12-10 16:51:24 +01:00
Code Issues Projects Releases Packages Wiki Activity

Fixed bug with metadata config of array/date facets, closes #1552

Browse source 
Thanks @davidbgk for spotting the fix for the bug.
This commit is contained in:
Simon Willison 2021-12-16 10:47:22 -08:00
commit 20a2ed6bec
3 changed files with 43 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

25
tests/test_facets.py
View file

@ -3,7 +3,7 @@ from datasette.database import Database
from datasette.facets import ColumnFacet, ArrayFacet, DateFacet
from datasette.utils.asgi import Request
from datasette.utils import detect_json1
from .fixtures import app_client # noqa
from .fixtures import app_client, make_app_client # noqa
import json
import pytest
@ -588,3 +588,26 @@ async def test_facet_size():
)
data5 = response5.json()
assert len(data5["facet_results"]["city"]["results"]) == 20
def test_other_types_of_facet_in_metadata():
with make_app_client(
metadata={
"databases": {
"fixtures": {
"tables": {
"facetable": {
"facets": ["state", {"array": "tags"}, {"date": "created"}]
}
}
}
}
}
) as client:
response = client.get("/fixtures/facetable")
for fragment in (
"<strong>created (date)\n",
"<strong>tags (array)\n",
"<strong>state\n",
):
assert fragment in response.text