github/datasette
1
0
Fork 0
mirror of https://github.com/simonw/datasette.git synced 2025-12-10 16:51:24 +01:00
Code Issues Projects Releases Packages Wiki Activity

Explicitly order by pk (or by rowid)

Browse source 
Refs #5
This commit is contained in:
Simon Willison 2017-11-09 08:11:14 -08:00
commit 292f140a4f
1 changed files with 10 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

14
immutabase/app.py
View file

@ -256,16 +256,22 @@ class TableView(BaseView):
table = urllib.parse.unquote_plus(table) table = urllib.parse.unquote_plus(table)
pks = await self.pks_for_table(name, table) pks = await self.pks_for_table(name, table)
use_rowid = not pks use_rowid = not pks
select = '*'
if use_rowid: if use_rowid:
select = 'rowid, *' select = 'rowid, *'
order_by = 'rowid'
else:
select = '*'
order_by = ', '.join(pks)
if request.args: if request.args:
where_clause, params = build_where_clause(request.args) where_clause, params = build_where_clause(request.args)
sql = 'select {} from "{}" where {} limit 50'.format( sql = 'select {} from "{}" where {} order by {} limit 50'.format(
select, table, where_clause select, table, where_clause, order_by
) )
else: else:
sql = 'select {} from "{}" limit 50'.format(select, table) sql = 'select {} from "{}" order by {} limit 50'.format(
select, table, order_by
)
params = [] params = []
rows = await self.execute(name, sql, params) rows = await self.execute(name, sql, params)