github/datasette
1
0
Fork 0
mirror of https://github.com/simonw/datasette.git synced 2025-12-10 16:51:24 +01:00
Code Issues Projects Releases Packages Wiki Activity

Fixed #216 - paginate correctly when sorting by nullable column

Browse source
This commit is contained in:
Simon Willison 2018-04-16 16:51:51 -07:00
commit 2abe539a0f
No known key found for this signature in database
GPG key ID: 17E2DEA2588B7F52
3 changed files with 60 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

5
tests/fixtures.py
View file

@ -55,6 +55,7 @@ def generate_sortable_rows(num):
'sortable_with_nulls_2': rand.choice([
None, rand.random(), rand.random()
]),
'text': rand.choice(['$null', '$blah']),
}
@ -78,6 +79,7 @@ METADATA = {
'sortable',
'sortable_with_nulls',
'sortable_with_nulls_2',
'text',
]
},
'no_primary_key': {
@ -153,6 +155,7 @@ CREATE TABLE sortable (
sortable integer,
sortable_with_nulls real,
sortable_with_nulls_2 real,
text text,
PRIMARY KEY (pk1, pk2)
);
@ -235,7 +238,7 @@ CREATE VIEW simple_view AS
]) + '\n'.join([
'''INSERT INTO sortable VALUES (
"{pk1}", "{pk2}", "{content}", {sortable},
{sortable_with_nulls}, {sortable_with_nulls_2});
{sortable_with_nulls}, {sortable_with_nulls_2}, "{text}");
'''.format(
**row
).replace('None', 'null') for row in generate_sortable_rows(201)