From 2f81552cd29125e3916763f05949125a49c2dde8 Mon Sep 17 00:00:00 2001 From: Simon Willison Date: Tue, 15 May 2018 00:05:10 -0300 Subject: [PATCH] Never suggest a facet if it only results in on option --- datasette/views/table.py | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/datasette/views/table.py b/datasette/views/table.py index 037e170c..149aad49 100644 --- a/datasette/views/table.py +++ b/datasette/views/table.py @@ -592,17 +592,18 @@ class TableView(RowTableShared): and_or_where='and' if where_clauses else 'where', limit=FACET_LIMIT+1 ) - print(suggested_facet_sql) distinct_values = None try: distinct_values = await self.execute( name, suggested_facet_sql, params, truncate=False, custom_time_limit=50 ) + num_distinct_values = len(distinct_values) if ( - distinct_values and - len(distinct_values) <= FACET_LIMIT and - len(distinct_values) < filtered_table_rows_count + num_distinct_values and + num_distinct_values > 1 and + num_distinct_values <= FACET_LIMIT and + num_distinct_values < filtered_table_rows_count ): suggested_facets.append({ 'name': facet_column,