mirror of
https://github.com/simonw/datasette.git
synced 2025-12-10 16:51:24 +01:00
Use inspect-file, if possible, for total row count (#666)
For large tables, counting the number of rows in the table can take a significant amount of time. Instead, where an inspect-file is provided for an immutable database, look up the row-count for a plain count(*). Thanks, @kevindkeogh
This commit is contained in:
parent
6cb65555f4
commit
3041c6b641
3 changed files with 25 additions and 1 deletions
|
|
@ -11,6 +11,7 @@ from .fixtures import ( # noqa
|
|||
app_client_conflicting_database_names,
|
||||
app_client_with_cors,
|
||||
app_client_with_dot,
|
||||
app_client_immutable_and_inspect_file,
|
||||
generate_compound_rows,
|
||||
generate_sortable_rows,
|
||||
make_app_client,
|
||||
|
|
@ -1779,3 +1780,8 @@ def test_null_foreign_keys_are_not_expanded(app_client):
|
|||
},
|
||||
{"pk": "2", "foreign_key_with_label": None, "foreign_key_with_no_label": None,},
|
||||
] == response.json
|
||||
|
||||
|
||||
def test_inspect_file_used_for_count(app_client_immutable_and_inspect_file):
|
||||
response = app_client_immutable_and_inspect_file.get("/fixtures/sortable.json")
|
||||
assert response.json["filtered_table_rows_count"] == 100
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue