github/datasette
1
0
Fork 0
mirror of https://github.com/simonw/datasette.git synced 2025-12-10 16:51:24 +01:00
Code Issues Projects Releases Packages Wiki Activity

gcloud run is now GA, s/beta// (#660)

Browse source 
Thanks, @glasnt
This commit is contained in:
Katie McLaughlin 2020-01-22 10:28:11 +11:00 • committed by Simon Willison
commit 34d77d780f
3 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

4
datasette/publish/cloudrun.py
View file

@ -127,7 +127,7 @@ def publish_subcommand(publish):
image_id = "gcr.io/{project}/{name}".format(project=project, name=name)
check_call("gcloud builds submit --tag {}".format(image_id), shell=True)
check_call(
"gcloud beta run deploy --allow-unauthenticated --platform=managed --image {} {}".format(
"gcloud run deploy --allow-unauthenticated --platform=managed --image {} {}".format(
image_id, service,
),
shell=True,
@ -137,7 +137,7 @@ def publish_subcommand(publish):
def get_existing_services():
services = json.loads(
check_output(
"gcloud beta run services list --platform=managed --format json",
"gcloud run services list --platform=managed --format json",
shell=True,
universal_newlines=True,
)

2
docs/publish.rst
View file

@ -37,7 +37,7 @@ You can specify a custom app name by passing ``-n my-app-name`` to the publish c
Publishing to Google Cloud Run
------------------------------
`Google Cloud Run <https://cloud.google.com/run/>`__ launched as a beta in in April 2019. It allows you to publish data in a scale-to-zero environment, so your application will start running when the first request is received and will shut down again when traffic ceases. This means you only pay for time spent serving traffic.
`Google Cloud Run <https://cloud.google.com/run/>`__ launched as a GA in in November 2019. It allows you to publish data in a scale-to-zero environment, so your application will start running when the first request is received and will shut down again when traffic ceases. This means you only pay for time spent serving traffic.
You will first need to install and configure the Google Cloud CLI tools by following `these instructions <https://cloud.google.com/sdk/>`__.

4
tests/test_publish_cloudrun.py
View file

@ -62,7 +62,7 @@ Service name: input-service
[
mock.call("gcloud builds submit --tag {}".format(tag), shell=True),
mock.call(
"gcloud beta run deploy --allow-unauthenticated --platform=managed --image {} input-service".format(
"gcloud run deploy --allow-unauthenticated --platform=managed --image {} input-service".format(
tag
),
shell=True,
@ -89,7 +89,7 @@ def test_publish_cloudrun(mock_call, mock_output, mock_which):
[
mock.call("gcloud builds submit --tag {}".format(tag), shell=True),
mock.call(
"gcloud beta run deploy --allow-unauthenticated --platform=managed --image {} test".format(
"gcloud run deploy --allow-unauthenticated --platform=managed --image {} test".format(
tag
),
shell=True,