From 3b68314d8f59d92fe7b2150cf747a082192ef9b7 Mon Sep 17 00:00:00 2001 From: Simon Willison Date: Wed, 25 Jul 2018 22:45:47 -0700 Subject: [PATCH] Unit tests for publish now/heroku - closes #348 --- tests/test_publish_heroku.py | 74 ++++++++++++++++++++++++++++++++++++ tests/test_publish_now.py | 49 ++++++++++++++++++++++++ 2 files changed, 123 insertions(+) create mode 100644 tests/test_publish_heroku.py create mode 100644 tests/test_publish_now.py diff --git a/tests/test_publish_heroku.py b/tests/test_publish_heroku.py new file mode 100644 index 00000000..3d8fb6e6 --- /dev/null +++ b/tests/test_publish_heroku.py @@ -0,0 +1,74 @@ +from click.testing import CliRunner +from datasette import cli +from unittest import mock + + +@mock.patch("shutil.which") +def test_publish_heroku_requires_heroku(mock_which): + mock_which.return_value = False + runner = CliRunner() + with runner.isolated_filesystem(): + open("test.db", "w").write("data") + result = runner.invoke(cli.cli, ["publish", "heroku", "test.db"]) + assert result.exit_code == 1 + assert "Publishing to Heroku requires heroku" in result.output + + +@mock.patch("shutil.which") +@mock.patch("datasette.publish.heroku.check_output") +@mock.patch("datasette.publish.heroku.call") +def test_publish_heroku_installs_plugin(mock_call, mock_check_output, mock_which): + mock_which.return_value = True + mock_check_output.side_effect = lambda s: {"['heroku', 'plugins']": b""}[repr(s)] + runner = CliRunner() + with runner.isolated_filesystem(): + open("t.db", "w").write("data") + result = runner.invoke(cli.cli, ["publish", "heroku", "t.db"], input="y\n") + assert -1 == result.exit_code + mock_check_output.assert_has_calls( + [mock.call(["heroku", "plugins"]), mock.call(["heroku", "apps:list", "--json"])] + ) + mock_call.assert_has_calls( + [mock.call(["heroku", "plugins:install", "heroku-builds"])] + ) + + +@mock.patch("shutil.which") +def test_publish_heroku_invalid_database(mock_which): + mock_which.return_value = True + runner = CliRunner() + result = runner.invoke(cli.cli, ["publish", "heroku", "woop.db"]) + assert result.exit_code == 2 + assert 'Path "woop.db" does not exist' in result.output + + +@mock.patch("shutil.which") +@mock.patch("datasette.publish.heroku.check_output") +@mock.patch("datasette.publish.heroku.call") +def test_publish_heroku(mock_call, mock_check_output, mock_which): + mock_which.return_varue = True + mock_check_output.side_effect = lambda s: { + "['heroku', 'plugins']": b"heroku-builds", + "['heroku', 'apps:list', '--json']": b"[]", + "['heroku', 'apps:create', 'datasette', '--json']": b'{"name": "f"}', + }[repr(s)] + runner = CliRunner() + with runner.isolated_filesystem(): + open("test.db", "w").write("data") + result = runner.invoke(cli.cli, ["publish", "heroku", "test.db"]) + assert 0 == result.exit_code, result.output + mock_call.assert_called_once_with(["heroku", "builds:create", "-a", "f"]) + + +@mock.patch("shutil.which") +@mock.patch("datasette.publish.now.call") +def test_publish_now_force_token(mock_call, mock_which): + mock_which.return_value = True + runner = CliRunner() + with runner.isolated_filesystem(): + open("test.db", "w").write("data") + result = runner.invoke( + cli.cli, ["publish", "now", "test.db", "--force", "--token=X"] + ) + assert 0 == result.exit_code + mock_call.assert_called_once_with(["now", "--force", "--token=X"]) diff --git a/tests/test_publish_now.py b/tests/test_publish_now.py new file mode 100644 index 00000000..940a8292 --- /dev/null +++ b/tests/test_publish_now.py @@ -0,0 +1,49 @@ +from click.testing import CliRunner +from datasette import cli +from unittest import mock + + +@mock.patch("shutil.which") +def test_publish_now_requires_now(mock_which): + mock_which.return_value = False + runner = CliRunner() + with runner.isolated_filesystem(): + open("test.db", "w").write("data") + result = runner.invoke(cli.cli, ["publish", "now", "test.db"]) + assert result.exit_code == 1 + assert "Publishing to Zeit Now requires now" in result.output + + +@mock.patch("shutil.which") +def test_publish_now_invalid_database(mock_which): + mock_which.return_value = True + runner = CliRunner() + result = runner.invoke(cli.cli, ["publish", "now", "woop.db"]) + assert result.exit_code == 2 + assert 'Path "woop.db" does not exist' in result.output + + +@mock.patch("shutil.which") +@mock.patch("datasette.publish.now.call") +def test_publish_now(mock_call, mock_which): + mock_which.return_value = True + runner = CliRunner() + with runner.isolated_filesystem(): + open("test.db", "w").write("data") + result = runner.invoke(cli.cli, ["publish", "now", "test.db"]) + assert 0 == result.exit_code + mock_call.assert_called_once_with("now") + + +@mock.patch("shutil.which") +@mock.patch("datasette.publish.now.call") +def test_publish_now_force_token(mock_call, mock_which): + mock_which.return_value = True + runner = CliRunner() + with runner.isolated_filesystem(): + open("test.db", "w").write("data") + result = runner.invoke( + cli.cli, ["publish", "now", "test.db", "--force", "--token=X"] + ) + assert 0 == result.exit_code + mock_call.assert_called_once_with(["now", "--force", "--token=X"])