github/datasette
1
0
Fork 0
mirror of https://github.com/simonw/datasette.git synced 2025-12-10 16:51:24 +01:00
Code Issues Projects Releases Packages Wiki Activity

Fixed bug where tables with a column called n caused 500 errors

Browse source 
Closes #1228
This commit is contained in:
Simon Willison 2022-03-18 18:37:54 -07:00
commit 4e47a2d894
7 changed files with 59 additions and 37 deletions
Download patch file Download diff file Expand all files Collapse all files

6
tests/test_plugins.py
View file

@ -442,6 +442,7 @@ def test_hook_register_output_renderer_all_parameters(app_client):
"tags",
"complex_array",
"distinct_some_null",
"n",
],
"rows": [
"<sqlite3.Row object at 0xXXX>",
@ -460,7 +461,7 @@ def test_hook_register_output_renderer_all_parameters(app_client):
"<sqlite3.Row object at 0xXXX>",
"<sqlite3.Row object at 0xXXX>",
],
"sql": "select pk, created, planet_int, on_earth, state, _city_id, _neighborhood, tags, complex_array, distinct_some_null from facetable order by pk limit 51",
"sql": "select pk, created, planet_int, on_earth, state, _city_id, _neighborhood, tags, complex_array, distinct_some_null, n from facetable order by pk limit 51",
"query_name": None,
"database": "fixtures",
"table": "facetable",
@ -531,8 +532,9 @@ def test_hook_register_output_renderer_can_render(app_client):
"tags",
"complex_array",
"distinct_some_null",
"n",
],
"sql": "select pk, created, planet_int, on_earth, state, _city_id, _neighborhood, tags, complex_array, distinct_some_null from facetable order by pk limit 51",
"sql": "select pk, created, planet_int, on_earth, state, _city_id, _neighborhood, tags, complex_array, distinct_some_null, n from facetable order by pk limit 51",
"query_name": None,
"database": "fixtures",
"table": "facetable",