github/datasette
1
0
Fork 0
mirror of https://github.com/simonw/datasette.git synced 2025-12-10 16:51:24 +01:00
Code Issues Projects Releases Packages Wiki Activity

Fixed CSV tests - Python 3.6.5 and 3.6.3 apparently differ

Browse source 
The test used to expect CSV to come back like this:

	hello
	world
	""

With the final blank value encoded in quotes.

Judging by Travis failures, this behaviour changed between Python 3.6.3 and
3.6.5:

	https://travis-ci.org/simonw/datasette/jobs/392586661
This commit is contained in:
Simon Willison 2018-06-15 00:01:48 -07:00
commit 5bda4a477c
No known key found for this signature in database
GPG key ID: 17E2DEA2588B7F52
1 changed files with 1 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
tests/test_csv.py
View file

@ -9,7 +9,6 @@ EXPECTED_TABLE_CSV = '''id,content
EXPECTED_CUSTOM_CSV = '''content
hello
world
""
'''.replace('\n', '\r\n')
@ -22,7 +21,7 @@ def test_table_csv(app_client):
def test_custom_sql_csv(app_client):
response = app_client.get(
'/test_tables.csv?sql=select+content+from+simple_primary_key'
'/test_tables.csv?sql=select+content+from+simple_primary_key+limit+2'
)
assert response.status == 200
assert 'text/plain; charset=utf-8' == response.headers['Content-Type']