github/datasette
1
0
Fork 0
mirror of https://github.com/simonw/datasette.git synced 2025-12-10 16:51:24 +01:00
Code Issues Projects Releases Packages Wiki Activity

CSV export now respects --cors, fixes #326

Browse source
This commit is contained in:
Simon Willison 2018-06-23 17:59:37 -07:00
commit 64c2fea8df
No known key found for this signature in database
GPG key ID: 17E2DEA2588B7F52
3 changed files with 40 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

14
tests/test_csv.py
View file

@ -1,4 +1,8 @@
from .fixtures import app_client, app_client_csv_max_mb_one # noqa
from .fixtures import ( # noqa
app_client,
app_client_csv_max_mb_one,
app_client_with_cors
)
EXPECTED_TABLE_CSV = '''id,content
1,hello
@ -30,13 +34,21 @@ pk,planet_int,on_earth,state,city_id,city_id_label,neighborhood
15,2,0,MC,4,Memnonia,Arcadia Planitia
'''.lstrip().replace('\n', '\r\n')
def test_table_csv(app_client):
response = app_client.get('/fixtures/simple_primary_key.csv')
assert response.status == 200
assert not response.headers.get("Access-Control-Allow-Origin")
assert 'text/plain; charset=utf-8' == response.headers['Content-Type']
assert EXPECTED_TABLE_CSV == response.text
def test_table_csv_cors_headers(app_client_with_cors):
response = app_client_with_cors.get('/fixtures/simple_primary_key.csv')
assert response.status == 200
assert "*" == response.headers["Access-Control-Allow-Origin"]
def test_table_csv_with_labels(app_client):
response = app_client.get('/fixtures/facetable.csv?_labels=1')
assert response.status == 200