From 653475edde4cd083128f3a39789ca1ec83f1f2e0 Mon Sep 17 00:00:00 2001 From: Simon Willison Date: Sat, 25 Oct 2025 21:34:30 -0700 Subject: [PATCH] Fix permissions_debug.html to use takes_parent/takes_child, refs #2530 The JavaScript was still referencing the old field names takes_database and takes_resource instead of the new takes_parent and takes_child. This caused the resource input fields to not show/hide properly when selecting different permission actions. --- datasette/templates/permissions_debug.html | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/datasette/templates/permissions_debug.html b/datasette/templates/permissions_debug.html index 5a84e8b7..1872da33 100644 --- a/datasette/templates/permissions_debug.html +++ b/datasette/templates/permissions_debug.html @@ -77,13 +77,13 @@ var resource1 = document.getElementById('resource_1'); var resource2 = document.getElementById('resource_2'); function updateResourceVisibility() { var permission = permissionSelect.value; - var {takes_database, takes_resource} = permissions[permission]; - if (takes_database) { + var {takes_parent, takes_child} = permissions[permission]; + if (takes_parent) { resource1.closest('p').style.display = 'block'; } else { resource1.closest('p').style.display = 'none'; } - if (takes_resource) { + if (takes_child) { resource2.closest('p').style.display = 'block'; } else { resource2.closest('p').style.display = 'none';