github/datasette
1
0
Fork 0
mirror of https://github.com/simonw/datasette.git synced 2025-12-10 16:51:24 +01:00
Code Issues Projects Releases Packages Wiki Activity

Hide shadow tables, don't hide virtual tables

Browse source 
Closes #2296
This commit is contained in:
Alex Garcia 2024-08-15 13:19:22 -07:00 • committed by GitHub
commit 6d91d082e0
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 161 additions and 52 deletions
Download patch file Download diff file Expand all files Collapse all files

3
tests/test_html.py
View file

@ -41,13 +41,14 @@ def test_homepage(app_client_two_attached_databases):
assert "extra database" == h2.text.strip()
counts_p, links_p = h2.find_all_next("p")[:2]
assert (
"2 rows in 1 table, 5 rows in 4 hidden tables, 1 view" == counts_p.text.strip()
"4 rows in 2 tables, 3 rows in 3 hidden tables, 1 view" == counts_p.text.strip()
)
# We should only show visible, not hidden tables here:
table_links = [
{"href": a["href"], "text": a.text.strip()} for a in links_p.findAll("a")
]
assert [
{"href": r"/extra+database/searchable_fts", "text": "searchable_fts"},
{"href": r"/extra+database/searchable", "text": "searchable"},
{"href": r"/extra+database/searchable_view", "text": "searchable_view"},
] == table_links