github/datasette
1
0
Fork 0
mirror of https://github.com/simonw/datasette.git synced 2025-12-10 16:51:24 +01:00
Code Issues Projects Releases Packages Wiki Activity

utils.path_with_added_args() improvements

Browse source 
* Now covered by unit tests
* Preserves original order
* Can handle multiple args of the same name, e.g. ?bar=1&bar=2
This commit is contained in:
Simon Willison 2018-05-12 18:35:25 -03:00
commit 70ff615f1b
No known key found for this signature in database
GPG key ID: 17E2DEA2588B7F52
3 changed files with 29 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

6
tests/test_html.py
View file

@ -65,7 +65,7 @@ def test_add_filter_redirects(app_client):
path = path_base + '?foo=bar&' + filter_args
response = app_client.get(path, allow_redirects=False, gather_request=False)
assert response.status == 302
assert response.headers['Location'].endswith('?content__startswith=x&foo=bar')
assert response.headers['Location'].endswith('?foo=bar&content__startswith=x')
# Test that op with a __x suffix overrides the filter value
path = path_base + '?' + urllib.parse.urlencode({
@ -100,7 +100,7 @@ def test_existing_filter_redirects(app_client):
response = app_client.get(path, allow_redirects=False, gather_request=False)
assert response.status == 302
assert response.headers['Location'].endswith(
'?age__gte=22&age__lt=30&name__contains=hello&name__contains=world'
'?name__contains=hello&age__gte=22&age__lt=30&name__contains=world'
)
# Setting _filter_column_3 to empty string should remove *_3 entirely
@ -109,7 +109,7 @@ def test_existing_filter_redirects(app_client):
response = app_client.get(path, allow_redirects=False, gather_request=False)
assert response.status == 302
assert response.headers['Location'].endswith(
'?age__gte=22&name__contains=hello&name__contains=world'
'?name__contains=hello&age__gte=22&name__contains=world'
)
# ?_filter_op=exact should be removed if unaccompanied by _fiter_column