github/datasette
1
0
Fork 0
mirror of https://github.com/simonw/datasette.git synced 2025-12-10 16:51:24 +01:00
Code Issues Projects Releases Packages Wiki Activity

Fixed bug with ?_sort= and ?_search=, closes #1214

Browse source
This commit is contained in:
Simon Willison 2021-02-02 13:20:53 -08:00
commit 7a2ed9f8a1
2 changed files with 18 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
datasette/views/table.py
View file

@ -815,7 +815,7 @@ class TableView(RowTableShared):
form_hidden_args = [] form_hidden_args = []
for key in request.args: for key in request.args:
if key.startswith("_"): if key.startswith("_") and key not in ("_sort", "_search"):
for value in request.args.getlist(key): for value in request.args.getlist(key):
form_hidden_args.append((key, value)) form_hidden_args.append((key, value))

17
tests/test_html.py
View file

@ -1272,6 +1272,23 @@ def test_other_hidden_form_fields(app_client, path, expected_hidden):
assert [(hidden["name"], hidden["value"]) for hidden in hiddens] == expected_hidden assert [(hidden["name"], hidden["value"]) for hidden in hiddens] == expected_hidden
@pytest.mark.parametrize(
"path,expected_hidden",
[
("/fixtures/searchable?_search=terry", []),
("/fixtures/searchable?_sort=text2", []),
("/fixtures/searchable?_sort=text2&_where=1", [("_where", "1")]),
],
)
def test_search_and_sort_fields_not_duplicated(app_client, path, expected_hidden):
# https://github.com/simonw/datasette/issues/1214
response = app_client.get(path)
soup = Soup(response.body, "html.parser")
inputs = soup.find("form").findAll("input")
hiddens = [i for i in inputs if i["type"] == "hidden"]
assert [(hidden["name"], hidden["value"]) for hidden in hiddens] == expected_hidden
def test_binary_data_display_in_table(app_client): def test_binary_data_display_in_table(app_client):
response = app_client.get("/fixtures/binary_data") response = app_client.get("/fixtures/binary_data")
assert response.status == 200 assert response.status == 200