github/datasette
1
0
Fork 0
mirror of https://github.com/simonw/datasette.git synced 2025-12-10 16:51:24 +01:00
Code Issues Projects Releases Packages Wiki Activity

Call _prepare_connection() on write connections, closes #1564

Browse source
This commit is contained in:
Simon Willison 2021-12-17 17:58:39 -08:00
commit 83bacfa945
2 changed files with 7 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
datasette/database.py
View file

@ -128,6 +128,7 @@ class Database:
conn = None conn = None
try: try:
conn = self.connect(write=True) conn = self.connect(write=True)
self.ds._prepare_connection(conn, self.name)
except Exception as e: except Exception as e:
conn_exception = e conn_exception = e
while True: while True:

6
tests/test_internals_database.py
View file

@ -396,6 +396,12 @@ async def test_execute_write_block_false(db):
assert "Mystery!" == rows.rows[0][0] assert "Mystery!" == rows.rows[0][0]
@pytest.mark.asyncio
async def test_execute_write_has_correctly_prepared_connection(db):
# The sleep() function is only available if ds._prepare_connection() was called
await db.execute_write("select sleep(0.01)", block=True)
@pytest.mark.asyncio @pytest.mark.asyncio
async def test_execute_write_fn_block_false(db): async def test_execute_write_fn_block_false(db):
def write_fn(conn): def write_fn(conn):