github/datasette
1
0
Fork 0
mirror of https://github.com/simonw/datasette.git synced 2025-12-10 16:51:24 +01:00
Code Issues Projects Releases Packages Wiki Activity

transfer-encoding: chunked for DB downloads, refs #749

Browse source 
This should get >32MB downloads working on Cloud Run.
This commit is contained in:
Simon Willison 2020-12-02 15:47:37 -08:00
commit 88ac538b41
2 changed files with 2 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
datasette/views/database.py
View file

@ -169,6 +169,7 @@ class DatabaseDownload(DataView):
headers = {} headers = {}
if self.ds.cors: if self.ds.cors:
headers["Access-Control-Allow-Origin"] = "*" headers["Access-Control-Allow-Origin"] = "*"
headers["Transfer-Encoding"] = "chunked"
return AsgiFileDownload( return AsgiFileDownload(
filepath, filepath,
filename=os.path.basename(filepath), filename=os.path.basename(filepath),

1
tests/test_html.py
View file

@ -1028,6 +1028,7 @@ def test_database_download_for_immutable():
download_response.headers["content-disposition"] download_response.headers["content-disposition"]
== 'attachment; filename="fixtures.db"' == 'attachment; filename="fixtures.db"'
) )
assert download_response.headers["transfer-encoding"] == "chunked"
def test_database_download_disallowed_for_mutable(app_client): def test_database_download_disallowed_for_mutable(app_client):