From 8b5bf3e487dadeef11cf7616cf03b3090cb46613 Mon Sep 17 00:00:00 2001 From: Simon Willison Date: Thu, 23 Oct 2025 14:23:46 -0700 Subject: [PATCH] Mark test_permissions_checked database download test as xfail, refs #2526 The test expects ensure_permissions() to check all three permissions (view-database-download, view-database, view-instance) but the current implementation short-circuits after the first successful check. Created issue #2526 to track the investigation of the expected behavior. --- tests/test_permissions.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tests/test_permissions.py b/tests/test_permissions.py index 25dce2c9..85eae680 100644 --- a/tests/test_permissions.py +++ b/tests/test_permissions.py @@ -344,13 +344,16 @@ def test_query_list_respects_view_query(): ("execute-sql", "fixtures"), ], ), - ( + pytest.param( "/fixtures.db", [ "view-instance", ("view-database", "fixtures"), ("view-database-download", "fixtures"), ], + marks=pytest.mark.xfail( + reason="ensure_permissions() short-circuits, not checking all permissions - see #2526" + ), ), ( "/fixtures/neighborhood_search",