github/datasette
1
0
Fork 0
mirror of https://github.com/simonw/datasette.git synced 2025-12-10 16:51:24 +01:00
Code Issues Projects Releases Packages Wiki Activity

Consider every plugins opinion in datasette.permission_allowed()

Browse source 
Closes #2275, refs #2262
This commit is contained in:
Simon Willison 2024-02-16 13:29:39 -08:00
commit 8bfa3a51c2
2 changed files with 30 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

14
datasette/app.py
View file

@ -903,6 +903,8 @@ class Datasette:
# Use default from registered permission, if available
if default is DEFAULT_NOT_SET and action in self.permissions:
default = self.permissions[action].default
opinions = []
# Every plugin is consulted for their opinion
for check in pm.hook.permission_allowed(
datasette=self,
actor=actor,
@ -911,9 +913,19 @@ class Datasette:
):
check = await await_me_maybe(check)
if check is not None:
result = check
opinions.append(check)
result = None
# If any plugin said False it's false - the veto rule
if any(not r for r in opinions):
result = False
elif any(r for r in opinions):
# Otherwise, if any plugin said True it's true
result = True
used_default = False
if result is None:
# No plugin expressed an opinion, so use the default
result = default
used_default = True
self._permission_checks.append(