github/datasette
1
0
Fork 0
mirror of https://github.com/simonw/datasette.git synced 2025-12-10 16:51:24 +01:00
Code Issues Projects Releases Packages Wiki Activity

Fix test_tables_endpoint_config_database_allow by using unique database names

Browse source
This commit is contained in:
Simon Willison 2025-10-23 15:26:14 -07:00
commit 8de5b9431c
1 changed files with 20 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

40
tests/test_tables_endpoint.py
View file

@ -501,44 +501,44 @@ async def test_tables_endpoint_search_no_matches():
async def test_tables_endpoint_config_database_allow(): async def test_tables_endpoint_config_database_allow():
"""Test that database-level allow blocks work for view-table action""" """Test that database-level allow blocks work for view-table action"""
# Simulate: -s databases.fixtures.allow.id root # Simulate: -s databases.restricted_db.allow.id root
config = {"databases": {"fixtures": {"allow": {"id": "root"}}}} config = {"databases": {"restricted_db": {"allow": {"id": "root"}}}}
ds = Datasette(config=config) ds = Datasette(config=config)
await ds.invoke_startup() await ds.invoke_startup()
# Create databases # Create databases
fixtures_db = ds.add_memory_database("fixtures") restricted_db = ds.add_memory_database("restricted_db")
await fixtures_db.execute_write("CREATE TABLE users (id INTEGER)") await restricted_db.execute_write("CREATE TABLE users (id INTEGER)")
await fixtures_db.execute_write("CREATE TABLE posts (id INTEGER)") await restricted_db.execute_write("CREATE TABLE posts (id INTEGER)")
content_db = ds.add_memory_database("content") public_db = ds.add_memory_database("public_db")
await content_db.execute_write("CREATE TABLE articles (id INTEGER)") await public_db.execute_write("CREATE TABLE articles (id INTEGER)")
await ds._refresh_schemas() await ds._refresh_schemas()
# Root user should see fixtures tables # Root user should see restricted_db tables
root_tables = await ds.allowed_resources("view-table", {"id": "root"}) root_tables = await ds.allowed_resources("view-table", {"id": "root"})
root_list = [ root_list = [
{"name": f"{t.parent}/{t.child}", "url": ds.urls.table(t.parent, t.child)} {"name": f"{t.parent}/{t.child}", "url": ds.urls.table(t.parent, t.child)}
for t in root_tables for t in root_tables
] ]
fixtures_tables_root = [m for m in root_list if m["name"].startswith("fixtures/")] restricted_tables_root = [m for m in root_list if m["name"].startswith("restricted_db/")]
assert len(fixtures_tables_root) == 2 assert len(restricted_tables_root) == 2
table_names = {m["name"] for m in fixtures_tables_root} table_names = {m["name"] for m in restricted_tables_root}
assert "fixtures/users" in table_names assert "restricted_db/users" in table_names
assert "fixtures/posts" in table_names assert "restricted_db/posts" in table_names
# Alice should NOT see fixtures tables # Alice should NOT see restricted_db tables
alice_tables = await ds.allowed_resources("view-table", {"id": "alice"}) alice_tables = await ds.allowed_resources("view-table", {"id": "alice"})
alice_list = [ alice_list = [
{"name": f"{t.parent}/{t.child}", "url": ds.urls.table(t.parent, t.child)} {"name": f"{t.parent}/{t.child}", "url": ds.urls.table(t.parent, t.child)}
for t in alice_tables for t in alice_tables
] ]
fixtures_tables_alice = [m for m in alice_list if m["name"].startswith("fixtures/")] restricted_tables_alice = [m for m in alice_list if m["name"].startswith("restricted_db/")]
assert len(fixtures_tables_alice) == 0 assert len(restricted_tables_alice) == 0
# But Alice should see content tables (no restrictions) # But Alice should see public_db tables (no restrictions)
content_tables_alice = [m for m in alice_list if m["name"].startswith("content/")] public_tables_alice = [m for m in alice_list if m["name"].startswith("public_db/")]
assert len(content_tables_alice) == 1 assert len(public_tables_alice) == 1
assert "content/articles" in {m["name"] for m in content_tables_alice} assert "public_db/articles" in {m["name"] for m in public_tables_alice}