github/datasette
1
0
Fork 0
mirror of https://github.com/simonw/datasette.git synced 2025-12-10 16:51:24 +01:00
Code Issues Projects Releases Packages Wiki Activity

Use context manager instead of plain open (#1211)

Browse source 
Context manager with open closes the files after usage.

When the object is already a pathlib.Path i used read_text
write_text functions

In some cases pathlib.Path.open were used in context manager,
it is basically the same as builtin open.

Thanks, Konstantin Baikov!
This commit is contained in:
Konstantin Baikov 2021-03-11 17:15:49 +01:00 • committed by GitHub
commit 8e18c79431
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
17 changed files with 93 additions and 63 deletions
Download patch file Download diff file Expand all files Collapse all files

8
tests/test_docs.py
View file

@ -19,13 +19,13 @@ def get_headings(content, underline="-"):
def get_labels(filename):
content = (docs_path / filename).open().read()
content = (docs_path / filename).read_text()
return set(label_re.findall(content))
@pytest.fixture(scope="session")
def settings_headings():
return get_headings((docs_path / "settings.rst").open().read(), "~")
return get_headings((docs_path / "settings.rst").read_text(), "~")
@pytest.mark.parametrize("setting", app.SETTINGS)
@ -43,7 +43,7 @@ def test_settings_are_documented(settings_headings, setting):
),
)
def test_help_includes(name, filename):
expected = open(str(docs_path / filename)).read()
expected = (docs_path / filename).read_text()
runner = CliRunner()
result = runner.invoke(cli, name.split() + ["--help"], terminal_width=88)
actual = f"$ datasette {name} --help\n\n{result.output}"
@ -55,7 +55,7 @@ def test_help_includes(name, filename):
@pytest.fixture(scope="session")
def plugin_hooks_content():
return (docs_path / "plugin_hooks.rst").open().read()
return (docs_path / "plugin_hooks.rst").read_text()
@pytest.mark.parametrize(