github/datasette
1
0
Fork 0
mirror of https://github.com/simonw/datasette.git synced 2025-12-10 16:51:24 +01:00
Code Issues Projects Releases Packages Wiki Activity

Support nested JSON in metadata.json, closes #2403

Browse source
This commit is contained in:
Simon Willison 2024-08-21 09:53:52 -07:00
commit 9028d7f805
2 changed files with 9 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

5
datasette/app.py
View file

@ -450,7 +450,10 @@ class Datasette:
for key in self._metadata_local or {}: for key in self._metadata_local or {}:
if key == "databases": if key == "databases":
continue continue
await self.set_instance_metadata(key, self._metadata_local[key]) value = self._metadata_local[key]
if not isinstance(value, str):
value = json.dumps(value)
await self.set_instance_metadata(key, value)
# step 2: database-level metadata # step 2: database-level metadata
for dbname, db in self._metadata_local.get("databases", {}).items(): for dbname, db in self._metadata_local.get("databases", {}).items():

7
tests/test_internals_datasette.py
View file

@ -183,13 +183,16 @@ async def test_apply_metadata_json():
"legislators": { "legislators": {
"tables": {"offices": {"summary": "office address or sumtin"}}, "tables": {"offices": {"summary": "office address or sumtin"}},
"queries": { "queries": {
"millenntial_represetatives": { "millennial_representatives": {
"summary": "Social media accounts for current legislators" "summary": "Social media accounts for current legislators"
} }
}, },
} }
} },
"weird_instance_value": {"nested": [1, 2, 3]},
}, },
) )
await ds.invoke_startup() await ds.invoke_startup()
assert (await ds.client.get("/")).status_code == 200 assert (await ds.client.get("/")).status_code == 200
value = (await ds.get_instance_metadata()).get("weird_instance_value")
assert value == '{"nested": [1, 2, 3]}'