From 9172020535338d9e05840d38f87918b87d4c15af Mon Sep 17 00:00:00 2001 From: Simon Willison Date: Thu, 23 Oct 2025 15:48:48 -0700 Subject: [PATCH] Removed unneccessary isinstance(candidate, PermissionSQL) --- datasette/app.py | 2 -- datasette/views/special.py | 6 ------ 2 files changed, 8 deletions(-) diff --git a/datasette/app.py b/datasette/app.py index 40fc55be..2cf980e1 100644 --- a/datasette/app.py +++ b/datasette/app.py @@ -1090,8 +1090,6 @@ class Datasette: for candidate in candidates: if candidate is None: continue - if not isinstance(candidate, PermissionSQL): - continue plugin_blocks.append(candidate) sql, params = build_rules_union( diff --git a/datasette/views/special.py b/datasette/views/special.py index c0d3d453..b825c1c0 100644 --- a/datasette/views/special.py +++ b/datasette/views/special.py @@ -305,12 +305,6 @@ class AllowedResourcesView(BaseView): for candidate in candidates: if candidate is None: continue - if not isinstance(candidate, PermissionSQL): - logger.warning( - "Skipping permission_resources_sql result %r from plugin; expected PermissionSQL", - candidate, - ) - continue plugins.append(candidate) rows = await resolve_permissions_from_catalog(