From 93c65d29ba372fa2262a641c0fecb7a071d998d6 Mon Sep 17 00:00:00 2001 From: Simon Willison Date: Fri, 3 May 2019 16:40:24 -0400 Subject: [PATCH] Fixed 500 error on /-/metadata page --- datasette/views/special.py | 2 ++ tests/test_html.py | 11 +++++++++++ 2 files changed, 13 insertions(+) diff --git a/datasette/views/special.py b/datasette/views/special.py index 8f00cbec..d3530b28 100644 --- a/datasette/views/special.py +++ b/datasette/views/special.py @@ -4,6 +4,8 @@ from .base import RenderMixin class JsonDataView(RenderMixin): + name = "json_data" + def __init__(self, datasette, filename, data_callback): self.ds = datasette self.filename = filename diff --git a/tests/test_html.py b/tests/test_html.py index 402246c7..5114363a 100644 --- a/tests/test_html.py +++ b/tests/test_html.py @@ -5,7 +5,9 @@ from .fixtures import ( # noqa app_client_with_hash, app_client_with_memory, make_app_client, + METADATA, ) +import json import pytest import re import urllib.parse @@ -899,3 +901,12 @@ def test_binary_data_display(app_client): assert expected_tds == [ [str(td) for td in tr.select("td")] for tr in table.select("tbody tr") ] + + +def test_metadata_json_html(app_client): + response = app_client.get( + "/-/metadata" + ) + assert response.status == 200 + pre = Soup(response.body, "html.parser").find("pre") + assert METADATA == json.loads(pre.text)