github/datasette
1
0
Fork 0
mirror of https://github.com/simonw/datasette.git synced 2025-12-10 16:51:24 +01:00
Code Issues Projects Releases Packages Wiki Activity

404s ending in slash redirect to remove that slash, closes #309

Browse source
This commit is contained in:
Simon Willison 2018-06-21 08:13:07 -07:00
commit 97ae66ccab
No known key found for this signature in database
GPG key ID: 17E2DEA2588B7F52
2 changed files with 19 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

10
datasette/app.py
View file

@ -468,8 +468,16 @@ class Datasette:
RowView.as_view(self),
"/<db_name:[^/]+>/<table:[^/]+?>/<pk_path:[^/]+?><as_format:(\.jsono?)?$>",
)
self.register_custom_units()
# On 404 with a trailing slash redirect to path without that slash:
@app.middleware("response")
def redirect_on_404_with_trailing_slash(request, original_response):
print("redirect_on_404_with_trailing_slash", request, original_response)
if original_response.status == 404 and request.path.endswith("/"):
path = request.path.rstrip("/")
if request.query_string:
path = "{}?{}".format(path, request.query_string)
return response.redirect(path)
@app.exception(Exception)
def on_exception(request, exception):