github/datasette
1
0
Fork 0
mirror of https://github.com/simonw/datasette.git synced 2025-12-10 16:51:24 +01:00
Code Issues Projects Releases Packages Wiki Activity

Slight tweak to insert row API design, refs #1851

Browse source 
https://github.com/simonw/datasette/issues/1851#issuecomment-1292997608
This commit is contained in:
Simon Willison 2022-10-27 12:06:18 -07:00
commit a51608090b
2 changed files with 7 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

10
datasette/views/table.py
View file

@ -131,11 +131,11 @@ class TableView(DataView):
# TODO: handle form-encoded data
raise BadRequest("Must send JSON data")
data = json.loads(await request.post_body())
if "row" not in data:
raise BadRequest('Must send "row" data')
row = data["row"]
if "insert" not in data:
raise BadRequest('Must send a "insert" key containing a dictionary')
row = data["insert"]
if not isinstance(row, dict):
raise BadRequest("row must be a dictionary")
raise BadRequest("insert must be a dictionary")
# Verify all columns exist
columns = await db.table_columns(table_name)
pks = await db.primary_keys(table_name)
@ -165,7 +165,7 @@ class TableView(DataView):
).first()
return Response.json(
{
"row": dict(new_row),
"inserted_row": dict(new_row),
},
status=201,
)

4
docs/json_api.rst
View file

@ -476,7 +476,7 @@ This requires the :ref:`permissions_insert_row` permission.
Content-Type: application/json
Authorization: Bearer dstok_<rest-of-token>
{
"row": {
"insert": {
"column1": "value1",
"column2": "value2"
}
@ -487,7 +487,7 @@ If successful, this will return a ``201`` status code and the newly inserted row
.. code-block:: json
{
"row": {
"inserted_row": {
"id": 1,
"column1": "value1",
"column2": "value2"