Code cleanup: rename variables, remove WHERE 0 check, cleanup files, refs #2528

- Rename permission_name to action_name in debug templates for consistency
- Remove confusing WHERE 0 check from check_permission_for_resource()
- Rename tests/test_special.py to tests/test_search_tables.py
- Remove tests/vec.db that shouldn't have been committed

datasette/templates/debug_check.html

@@ -110,8 +110,8 @@
         <label for="action">Action (permission name):</label>
         <select id="action" name="action" required>
             <option value="">Select an action...</option>
-            {% for permission_name in sorted_actions %}
+            {% for action_name in sorted_actions %}
-            <option value="{{ permission_name }}">{{ permission_name }}</option>
+            <option value="{{ action_name }}">{{ action_name }}</option>
             {% endfor %}
         </select>
         <small>The permission action to check</small>

datasette/templates/debug_rules.html

@@ -26,8 +26,8 @@
             <label for="action">Action (permission name):</label>
             <select id="action" name="action" required>
                 <option value="">Select an action...</option>
-                {% for permission_name in sorted_actions %}
+                {% for action_name in sorted_actions %}
-                <option value="{{ permission_name }}">{{ permission_name }}</option>
+                <option value="{{ action_name }}">{{ action_name }}</option>
                 {% endfor %}
             </select>
             <small>The permission action to check</small>

datasette/utils/actions_sql.py

@@ -486,7 +486,7 @@ async def check_permission_for_resource(
     rules_union, all_params = await build_permission_rules_sql(datasette, actor, action)
 
     # If no rules (empty SQL), default deny
-    if not rules_union or rules_union.endswith("WHERE 0"):
+    if not rules_union:
         return False
 
     # Add parameters for the resource we're checking