github/datasette
1
0
Fork 0
mirror of https://github.com/simonw/datasette.git synced 2025-12-10 16:51:24 +01:00
Code Issues Projects Releases Packages Wiki Activity

Show more useful error message for SQL interrupted, closes #142

Browse source
This commit is contained in:
Simon Willison 2018-05-28 14:24:19 -07:00
commit b0a95da963
No known key found for this signature in database
GPG key ID: 17E2DEA2588B7F52
3 changed files with 25 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

15
tests/test_html.py
View file

@ -1,10 +1,11 @@
from bs4 import BeautifulSoup as Soup
from .fixtures import app_client
from .fixtures import app_client, app_client_shorter_time_limit
import pytest
import re
import urllib.parse
pytest.fixture(scope='session')(app_client)
pytest.fixture(scope='session')(app_client_shorter_time_limit)
def test_homepage(app_client):
@ -29,6 +30,18 @@ def test_invalid_custom_sql(app_client):
assert 'Statement must be a SELECT' in response.text
def test_sql_time_limit(app_client_shorter_time_limit):
response = app_client_shorter_time_limit.get(
'/test_tables?sql=select+sleep(0.5)',
gather_request=False
)
assert 400 == response.status
expected_html_fragment = """
<a href="https://datasette.readthedocs.io/en/stable/config.html#sql-time-limit-ms">sql_time_limit_ms</a>
""".strip()
assert expected_html_fragment in response.text
def test_view(app_client):
response = app_client.get('/test_tables/simple_view', gather_request=False)
assert response.status == 200