github/datasette
1
0
Fork 0
mirror of https://github.com/simonw/datasette.git synced 2025-12-10 16:51:24 +01:00
Code Issues Projects Releases Packages Wiki Activity

Use .custom_sql() for _group_count implementation (refs #150)

Browse source
This commit is contained in:
Simon Willison 2018-04-08 08:42:56 -07:00
commit b2188f0442
No known key found for this signature in database
GPG key ID: 17E2DEA2588B7F52
1 changed files with 1 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
datasette/app.py
View file

@ -644,13 +644,12 @@ class TableView(RowTableShared):
# _group_count=col1&_group_count=col2 # _group_count=col1&_group_count=col2
group_count = special_args_lists.get('_group_count') or [] group_count = special_args_lists.get('_group_count') or []
if group_count: if group_count:
count_sql = None
sql = 'select {group_cols}, count(*) as "count" from {table_name} {where} group by {group_cols} order by "count" desc limit 100'.format( sql = 'select {group_cols}, count(*) as "count" from {table_name} {where} group by {group_cols} order by "count" desc limit 100'.format(
group_cols=', '.join('"{}"'.format(group_count_col) for group_count_col in group_count), group_cols=', '.join('"{}"'.format(group_count_col) for group_count_col in group_count),
table_name=escape_sqlite(table), table_name=escape_sqlite(table),
where=where_clause, where=where_clause,
) )
is_view = True return await self.custom_sql(request, name, hash, sql, editable=True)
else: else:
count_sql = 'select count(*) from {table_name} {where}'.format( count_sql = 'select count(*) from {table_name} {where}'.format(
table_name=escape_sqlite(table), table_name=escape_sqlite(table),