github/datasette
1
0
Fork 0
mirror of https://github.com/simonw/datasette.git synced 2025-12-10 16:51:24 +01:00
Code Issues Projects Releases Packages Wiki Activity

Raise ValueError if Datasette(files=) is a string, refs #1985

Browse source
This commit is contained in:
Simon Willison 2023-01-11 10:12:53 -08:00
commit b7df546a45
2 changed files with 10 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
datasette/app.py
View file

@ -218,6 +218,8 @@ class Datasette:
self.config_dir = config_dir
self.pdb = pdb
self._secret = secret or secrets.token_hex(32)
if files is not None and isinstance(files, str):
raise ValueError("files= must be a list of paths, not a string")
self.files = tuple(files or []) + tuple(immutables or [])
if config_dir:
db_files = []

9
tests/test_internals_datasette.py
View file

@ -130,7 +130,14 @@ async def test_datasette_ensure_permissions_check_visibility(
@pytest.mark.asyncio
async def test_datasette_render_template_no_request():
# https://github.com/simonw/datasette/issues/1849
ds = Datasette([], memory=True)
ds = Datasette(memory=True)
await ds.invoke_startup()
rendered = await ds.render_template("error.html")
assert "Error " in rendered
def test_datasette_error_if_string_not_list(tmpdir):
# https://github.com/simonw/datasette/issues/1985
db_path = str(tmpdir / "data.db")
with pytest.raises(ValueError):
ds = Datasette(db_path)