github/datasette
1
0
Fork 0
mirror of https://github.com/simonw/datasette.git synced 2025-12-10 16:51:24 +01:00
Code Issues Projects Releases Packages Wiki Activity

Confirm table actions work on views, closes #1067

Browse source
This commit is contained in:
Simon Willison 2020-10-31 10:40:09 -07:00
commit b84cfe1b08
1 changed files with 5 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

9
tests/test_plugins.py
View file

@ -784,7 +784,8 @@ def test_hook_menu_links(app_client):
] ]
def test_hook_table_actions(app_client): @pytest.mark.parametrize("table_or_view", ["facetable", "simple_view"])
def test_hook_table_actions(app_client, table_or_view):
def get_table_actions_links(html): def get_table_actions_links(html):
soup = Soup(html, "html.parser") soup = Soup(html, "html.parser")
details = soup.find("details", {"class": "table-menu-links"}) details = soup.find("details", {"class": "table-menu-links"})
@ -792,12 +793,12 @@ def test_hook_table_actions(app_client):
return [] return []
return [{"label": a.text, "href": a["href"]} for a in details.select("a")] return [{"label": a.text, "href": a["href"]} for a in details.select("a")]
response = app_client.get("/fixtures/facetable") response = app_client.get("/fixtures/{}".format(table_or_view))
assert get_table_actions_links(response.text) == [] assert get_table_actions_links(response.text) == []
response_2 = app_client.get("/fixtures/facetable?_bot=1") response_2 = app_client.get("/fixtures/{}?_bot=1".format(table_or_view))
assert get_table_actions_links(response_2.text) == [ assert get_table_actions_links(response_2.text) == [
{"label": "From async", "href": "/"}, {"label": "From async", "href": "/"},
{"label": "Database: fixtures", "href": "/"}, {"label": "Database: fixtures", "href": "/"},
{"label": "Table: facetable", "href": "/"}, {"label": "Table: {}".format(table_or_view), "href": "/"},
] ]