github/datasette
1
0
Fork 0
mirror of https://github.com/simonw/datasette.git synced 2025-12-10 16:51:24 +01:00
Code Issues Projects Releases Packages Wiki Activity

Don't hang in db.execute_write_fn() if connection fails

Browse source 
Closes #935

Refs https://github.com/simonw/latest-datasette-with-all-plugins/issues/3
This commit is contained in:
Simon Willison 2020-08-15 15:35:31 -07:00 • committed by GitHub
commit b86f94883b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 32 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

17
tests/test_internals_database.py
View file

@ -189,6 +189,23 @@ async def test_execute_write_fn_exception(db):
await db.execute_write_fn(write_fn, block=True)
@pytest.mark.asyncio
@pytest.mark.timeout(1)
async def test_execute_write_fn_connection_exception(tmpdir, app_client):
path = str(tmpdir / "immutable.db")
sqlite3.connect(path).execute("vacuum")
db = Database(app_client.ds, path=path, is_mutable=False)
app_client.ds.add_database("immutable-db", db)
def write_fn(conn):
assert False
with pytest.raises(AssertionError):
await db.execute_write_fn(write_fn, block=True)
app_client.ds.remove_database("immutable-db")
@pytest.mark.asyncio
async def test_mtime_ns(db):
assert isinstance(db.mtime_ns, int)