From bc46066f9d96550286ac7694f18f44c8169a83a7 Mon Sep 17 00:00:00 2001 From: Simon Willison Date: Wed, 21 Aug 2024 14:38:11 -0700 Subject: [PATCH] Fix huge performance bug in DateFacet, refs #2407 --- datasette/facets.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/datasette/facets.py b/datasette/facets.py index f49575d9..dd149424 100644 --- a/datasette/facets.py +++ b/datasette/facets.py @@ -480,8 +480,8 @@ class DateFacet(Facet): # Does this column contain any dates in the first 100 rows? suggested_facet_sql = """ select date({column}) from ( - {sql} - ) where {column} glob "????-??-*" limit 100; + select * from ({sql}) limit 100 + ) where {column} glob "????-??-*" """.format( column=escape_sqlite(column), sql=self.sql )