From c30f07c58e410ee296b28aeabe4dc461dd40b435 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 5 Nov 2019 21:12:55 -0800
Subject: [PATCH] Removed _group_count=col feature, closes #504

---
 datasette/views/table.py | 12 ------------
 docs/json_api.rst        |  9 ---------
 2 files changed, 21 deletions(-)

diff --git a/datasette/views/table.py b/datasette/views/table.py
index 139ff80b..920693d7 100644
--- a/datasette/views/table.py
+++ b/datasette/views/table.py
@@ -499,18 +499,6 @@ class TableView(RowTableShared):
         if order_by:
             order_by = "order by {} ".format(order_by)
 
-        # _group_count=col1&_group_count=col2
-        group_count = special_args_lists.get("_group_count") or []
-        if group_count:
-            sql = 'select {group_cols}, count(*) as "count" from {table_name} {where} group by {group_cols} order by "count" desc limit 100'.format(
-                group_cols=", ".join(
-                    '"{}"'.format(group_count_col) for group_count_col in group_count
-                ),
-                table_name=escape_sqlite(table),
-                where=where_clause,
-            )
-            return await self.custom_sql(request, database, hash, sql, editable=True)
-
         extra_args = {}
         # Handle ?_size=500
         page_size = _size or request.raw_args.get("_size")
diff --git a/docs/json_api.rst b/docs/json_api.rst
index de70362c..e369bee7 100644
--- a/docs/json_api.rst
+++ b/docs/json_api.rst
@@ -321,15 +321,6 @@ Special table arguments
 
     Here's `an example <https://latest.datasette.io/fixtures/roadside_attractions?_through={%22table%22:%22roadside_attraction_characteristics%22,%22column%22:%22characteristic_id%22,%22value%22:%221%22}>`__.
 
-
-``?_group_count=COLUMN``
-    Executes a SQL query that returns a count of the number of rows matching
-    each unique value in that column, with the most common ordered first.
-
-``?_group_count=COLUMN1&_group_count=column2``
-    You can pass multiple ``_group_count`` columns to return counts against
-    unique combinations of those columns.
-
 ``?_next=TOKEN``
     Pagination by continuation token - pass the token that was returned in the
     ``"next"`` property by the previous page.