github/datasette
1
0
Fork 0
mirror of https://github.com/simonw/datasette.git synced 2025-12-10 16:51:24 +01:00
Code Issues Projects Releases Packages Wiki Activity

Remove undocumented sqlite_functions mechanism, closes #1567

Browse source
This commit is contained in:
Simon Willison 2021-12-17 17:54:39 -08:00
commit c35b84a2aa
3 changed files with 7 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

3
datasette/app.py
View file

@ -259,7 +259,6 @@ class Datasette:
with metadata_files[0].open() as fp: with metadata_files[0].open() as fp:
metadata = parse_metadata(fp.read()) metadata = parse_metadata(fp.read())
self._metadata_local = metadata or {} self._metadata_local = metadata or {}
self.sqlite_functions = []
self.sqlite_extensions = [] self.sqlite_extensions = []
for extension in sqlite_extensions or []: for extension in sqlite_extensions or []:
# Resolve spatialite, if requested # Resolve spatialite, if requested
@ -548,8 +547,6 @@ class Datasette:
def _prepare_connection(self, conn, database): def _prepare_connection(self, conn, database):
conn.row_factory = sqlite3.Row conn.row_factory = sqlite3.Row
conn.text_factory = lambda x: str(x, "utf-8", "replace") conn.text_factory = lambda x: str(x, "utf-8", "replace")
for name, num_args, func in self.sqlite_functions:
conn.create_function(name, num_args, func)
if self.sqlite_extensions: if self.sqlite_extensions:
conn.enable_load_extension(True) conn.enable_load_extension(True)
for extension in self.sqlite_extensions: for extension in self.sqlite_extensions:

1
tests/fixtures.py
View file

@ -153,7 +153,6 @@ def make_app_client(
template_dir=template_dir, template_dir=template_dir,
crossdb=crossdb, crossdb=crossdb,
) )
ds.sqlite_functions.append(("sleep", 1, lambda n: time.sleep(float(n))))
yield TestClient(ds) yield TestClient(ds)

7
tests/plugins/sleep_sql_function.py Normal file
View file

@ -0,0 +1,7 @@
from datasette import hookimpl
import time
@hookimpl
def prepare_connection(conn):
conn.create_function("sleep", 1, lambda n: time.sleep(float(n)))