github/datasette
1
0
Fork 0
mirror of https://github.com/simonw/datasette.git synced 2025-12-10 16:51:24 +01:00
Code Issues Projects Releases Packages Wiki Activity

Use to_css_class for table cell column classes

Browse source 
This ensures that columns with spaces in the name will still
generate usable CSS class names. Refs #209
This commit is contained in:
Simon Willison 2018-04-17 18:19:21 -07:00
commit dfb87d012c
No known key found for this signature in database
GPG key ID: 17E2DEA2588B7F52
2 changed files with 7 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

2
datasette/templates/_rows_and_columns.html
View file

@ -20,7 +20,7 @@
{% for row in display_rows %} {% for row in display_rows %}
<tr> <tr>
{% for cell in row %} {% for cell in row %}
<td class="col-{{ cell.column|lower }}">{{ cell.value }}</td> <td class="col-{{ cell.column|to_css_class }}">{{ cell.value }}</td>
{% endfor %} {% endfor %}
</tr> </tr>
{% endfor %} {% endfor %}

12
tests/test_html.py
View file

@ -183,13 +183,13 @@ def test_table_html_simple_primary_key(app_client):
assert ['nofollow'] == a['rel'] assert ['nofollow'] == a['rel']
assert [ assert [
[ [
'<td class="col-link"><a href="/test_tables/simple_primary_key/1">1</a></td>', '<td class="col-Link"><a href="/test_tables/simple_primary_key/1">1</a></td>',
'<td class="col-content">hello</td>' '<td class="col-content">hello</td>'
], [ ], [
'<td class="col-link"><a href="/test_tables/simple_primary_key/2">2</a></td>', '<td class="col-Link"><a href="/test_tables/simple_primary_key/2">2</a></td>',
'<td class="col-content">world</td>' '<td class="col-content">world</td>'
], [ ], [
'<td class="col-link"><a href="/test_tables/simple_primary_key/3">3</a></td>', '<td class="col-Link"><a href="/test_tables/simple_primary_key/3">3</a></td>',
'<td class="col-content"></td>' '<td class="col-content"></td>'
] ]
] == [[str(td) for td in tr.select('td')] for tr in table.select('tbody tr')] ] == [[str(td) for td in tr.select('td')] for tr in table.select('tbody tr')]
@ -226,7 +226,7 @@ def test_table_html_no_primary_key(app_client):
] == [th.string.strip() for th in table.select('thead th')[2:]] ] == [th.string.strip() for th in table.select('thead th')[2:]]
expected = [ expected = [
[ [
'<td class="col-link"><a href="/test_tables/no_primary_key/{}">{}</a></td>'.format(i, i), '<td class="col-Link"><a href="/test_tables/no_primary_key/{}">{}</a></td>'.format(i, i),
'<td class="col-rowid">{}</td>'.format(i), '<td class="col-rowid">{}</td>'.format(i),
'<td class="col-content">{}</td>'.format(i), '<td class="col-content">{}</td>'.format(i),
'<td class="col-a">a{}</td>'.format(i), '<td class="col-a">a{}</td>'.format(i),
@ -270,7 +270,7 @@ def test_table_html_compound_primary_key(app_client):
)) ))
expected = [ expected = [
[ [
'<td class="col-link"><a href="/test_tables/compound_primary_key/a,b">a,b</a></td>', '<td class="col-Link"><a href="/test_tables/compound_primary_key/a,b">a,b</a></td>',
'<td class="col-pk1">a</td>', '<td class="col-pk1">a</td>',
'<td class="col-pk2">b</td>', '<td class="col-pk2">b</td>',
'<td class="col-content">c</td>', '<td class="col-content">c</td>',
@ -285,7 +285,7 @@ def test_table_html_foreign_key_links(app_client):
table = Soup(response.body, 'html.parser').find('table') table = Soup(response.body, 'html.parser').find('table')
expected = [ expected = [
[ [
'<td class="col-link"><a href="/test_tables/foreign_key_references/1">1</a></td>', '<td class="col-Link"><a href="/test_tables/foreign_key_references/1">1</a></td>',
'<td class="col-foreign_key_with_label"><a href="/test_tables/simple_primary_key/1">hello</a>\xa0<em>1</em></td>', '<td class="col-foreign_key_with_label"><a href="/test_tables/simple_primary_key/1">hello</a>\xa0<em>1</em></td>',
'<td class="col-foreign_key_with_no_label"><a href="/test_tables/primary_key_multiple_columns/1">1</a></td>' '<td class="col-foreign_key_with_no_label"><a href="/test_tables/primary_key_multiple_columns/1">1</a></td>'
] ]