github/datasette
1
0
Fork 0
mirror of https://github.com/simonw/datasette.git synced 2025-12-10 16:51:24 +01:00
Code Issues Projects Releases Packages Wiki Activity

Persist _where= in hidden fields, closes #604

Browse source
This commit is contained in:
Simon Willison 2019-10-30 11:49:26 -07:00
commit e2c390500e
2 changed files with 9 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

3
datasette/views/table.py
View file

@ -721,6 +721,9 @@ class TableView(RowTableShared):
for arg in ("_fts_table", "_fts_pk"): for arg in ("_fts_table", "_fts_pk"):
if arg in special_args: if arg in special_args:
form_hidden_args.append((arg, special_args[arg])) form_hidden_args.append((arg, special_args[arg]))
if request.args["_where"]:
for where_text in request.args["_where"]:
form_hidden_args.append(("_where", where_text))
return { return {
"supports_search": bool(fts_table), "supports_search": bool(fts_table),
"search": search or "", "search": search or "",

6
tests/test_html.py
View file

@ -955,6 +955,12 @@ def test_extra_where_clauses(app_client):
"/fixtures/facetable?_where=city_id%3D1", "/fixtures/facetable?_where=city_id%3D1",
"/fixtures/facetable?_where=neighborhood%3D%27Dogpatch%27", "/fixtures/facetable?_where=neighborhood%3D%27Dogpatch%27",
] == hrefs ] == hrefs
# These should also be persisted as hidden fields
inputs = soup.find("form").findAll("input")
hiddens = [i for i in inputs if i["type"] == "hidden"]
assert [("_where", "neighborhood='Dogpatch'"), ("_where", "city_id=1")] == [
(hidden["name"], hidden["value"]) for hidden in hiddens
]
def test_binary_data_display(app_client): def test_binary_data_display(app_client):