datasette and datasette publish --version-note

This commit is contained in:
Simon Willison 2018-06-17 13:14:55 -07:00
commit ea0069ef44
No known key found for this signature in database
GPG key ID: 17E2DEA2588B7F52
3 changed files with 17 additions and 3 deletions

View file

@ -119,6 +119,7 @@ class Datasette:
plugins_dir=None, plugins_dir=None,
static_mounts=None, static_mounts=None,
config=None, config=None,
version_note=None,
): ):
self.files = files self.files = files
self.cache_headers = cache_headers self.cache_headers = cache_headers
@ -131,6 +132,7 @@ class Datasette:
self.plugins_dir = plugins_dir self.plugins_dir = plugins_dir
self.static_mounts = static_mounts or [] self.static_mounts = static_mounts or []
self.config = dict(DEFAULT_CONFIG, **(config or {})) self.config = dict(DEFAULT_CONFIG, **(config or {}))
self.version_note = version_note
self.executor = futures.ThreadPoolExecutor( self.executor = futures.ThreadPoolExecutor(
max_workers=self.config["num_sql_threads"] max_workers=self.config["num_sql_threads"]
) )
@ -298,12 +300,14 @@ class Datasette:
fts_versions.append(fts) fts_versions.append(fts)
except sqlite3.OperationalError: except sqlite3.OperationalError:
continue continue
datasette_version = {"version": __version__}
if self.version_note:
datasette_version["note"] = self.version_note
return { return {
"python": { "python": {
"version": ".".join(map(str, sys.version_info[:3])), "full": sys.version "version": ".".join(map(str, sys.version_info[:3])), "full": sys.version
}, },
"datasette": {"version": __version__}, "datasette": datasette_version,
"sqlite": { "sqlite": {
"version": sqlite_version, "version": sqlite_version,
"fts_versions": fts_versions, "fts_versions": fts_versions,

View file

@ -136,6 +136,7 @@ def inspect(files, inspect_file, sqlite_extensions):
@click.option( @click.option(
"--spatialite", is_flag=True, help="Enable SpatialLite extension" "--spatialite", is_flag=True, help="Enable SpatialLite extension"
) )
@click.option("--version-note", help="Additional note to show on /-/versions")
@click.option("--title", help="Title for metadata") @click.option("--title", help="Title for metadata")
@click.option("--license", help="License label for metadata") @click.option("--license", help="License label for metadata")
@click.option("--license_url", help="License URL for metadata") @click.option("--license_url", help="License URL for metadata")
@ -155,6 +156,7 @@ def publish(
static, static,
install, install,
spatialite, spatialite,
version_note,
**extra_metadata **extra_metadata
): ):
""" """
@ -200,6 +202,7 @@ def publish(
static, static,
install, install,
spatialite, spatialite,
version_note,
extra_metadata, extra_metadata,
): ):
args = [] args = []
@ -478,6 +481,7 @@ def package(
help="Set config option using configname:value datasette.readthedocs.io/en/latest/config.html", help="Set config option using configname:value datasette.readthedocs.io/en/latest/config.html",
multiple=True, multiple=True,
) )
@click.option("--version-note", help="Additional note to show on /-/versions")
@click.option( @click.option(
"--help-config", "--help-config",
is_flag=True, is_flag=True,
@ -497,6 +501,7 @@ def serve(
plugins_dir, plugins_dir,
static, static,
config, config,
version_note,
help_config, help_config,
): ):
"""Serve up specified SQLite database files with a web UI""" """Serve up specified SQLite database files with a web UI"""
@ -538,6 +543,7 @@ def serve(
plugins_dir=plugins_dir, plugins_dir=plugins_dir,
static_mounts=static, static_mounts=static,
config=dict(config), config=dict(config),
version_note=version_note,
) )
# Force initial hashing/table counting # Force initial hashing/table counting
ds.inspect() ds.inspect()

View file

@ -241,7 +241,7 @@ def escape_sqlite(s):
return '[{}]'.format(s) return '[{}]'.format(s)
def make_dockerfile(files, metadata_file, extra_options, branch, template_dir, plugins_dir, static, install, spatialite): def make_dockerfile(files, metadata_file, extra_options, branch, template_dir, plugins_dir, static, install, spatialite, version_note):
cmd = ['"datasette"', '"serve"', '"--host"', '"0.0.0.0"'] cmd = ['"datasette"', '"serve"', '"--host"', '"0.0.0.0"']
cmd.append('"' + '", "'.join(files) + '"') cmd.append('"' + '", "'.join(files) + '"')
cmd.extend(['"--cors"', '"--port"', '"8001"', '"--inspect-file"', '"inspect-data.json"']) cmd.extend(['"--cors"', '"--port"', '"8001"', '"--inspect-file"', '"inspect-data.json"'])
@ -251,6 +251,8 @@ def make_dockerfile(files, metadata_file, extra_options, branch, template_dir, p
cmd.extend(['"--template-dir"', '"templates/"']) cmd.extend(['"--template-dir"', '"templates/"'])
if plugins_dir: if plugins_dir:
cmd.extend(['"--plugins-dir"', '"plugins/"']) cmd.extend(['"--plugins-dir"', '"plugins/"'])
if version_note:
cmd.extend(['"--version-note"', '"{}"'.format(version_note)])
if static: if static:
for mount_point, _ in static: for mount_point, _ in static:
cmd.extend(['"--static"', '"{}:{}"'.format(mount_point, mount_point)]) cmd.extend(['"--static"', '"{}:{}"'.format(mount_point, mount_point)])
@ -293,6 +295,7 @@ def temporary_docker_directory(
static, static,
install, install,
spatialite, spatialite,
version_note,
extra_metadata=None extra_metadata=None
): ):
extra_metadata = extra_metadata or {} extra_metadata = extra_metadata or {}
@ -324,6 +327,7 @@ def temporary_docker_directory(
static, static,
install, install,
spatialite, spatialite,
version_note,
) )
os.chdir(datasette_dir) os.chdir(datasette_dir)
if metadata_content: if metadata_content: