From ea183b2ae3d557a370628e236fe606717c704e2a Mon Sep 17 00:00:00 2001 From: Simon Willison Date: Tue, 14 Nov 2017 21:08:46 -0800 Subject: [PATCH] Default to 127.0.0.1 not 0.0.0.0 Closes #98 --- README.md | 2 +- datasette/cli.py | 2 +- datasette/utils.py | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index c8e4793e..13f03598 100644 --- a/README.md +++ b/README.md @@ -84,7 +84,7 @@ http://localhost:8001/History/downloads.jsono will return that data as JSON in a Serve up specified SQLite database files with a web UI Options: - -h, --host TEXT host for server, defaults to 0.0.0.0 + -h, --host TEXT host for server, defaults to 127.0.0.1 -p, --port INTEGER port for server, defaults to 8001 --debug Enable debug mode - useful for development --reload Automatically reload if code change detected - diff --git a/datasette/cli.py b/datasette/cli.py index b034be48..d4f91bbe 100644 --- a/datasette/cli.py +++ b/datasette/cli.py @@ -108,7 +108,7 @@ def package(files, tag, metadata, extra_options, **extra_metadata): @cli.command() @click.argument('files', type=click.Path(exists=True), nargs=-1) -@click.option('-h', '--host', default='0.0.0.0', help='host for server, defaults to 0.0.0.0') +@click.option('-h', '--host', default='127.0.0.1', help='host for server, defaults to 127.0.0.1') @click.option('-p', '--port', default=8001, help='port for server, defaults to 8001') @click.option('--debug', is_flag=True, help='Enable debug mode - useful for development') @click.option('--reload', is_flag=True, help='Automatically reload if code change detected - useful for development') diff --git a/datasette/utils.py b/datasette/utils.py index 4d296838..74cd79f6 100644 --- a/datasette/utils.py +++ b/datasette/utils.py @@ -144,7 +144,7 @@ def escape_sqlite_table_name(s): def make_dockerfile(files, metadata_file, extra_options=''): - cmd = ['"datasette"', '"serve"'] + cmd = ['"datasette"', '"serve"', '"--host"', '"0.0.0.0"'] cmd.append('"' + '", "'.join(files) + '"') cmd.extend(['"--cors"', '"--port"', '"8001"', '"--inspect-file"', '"inspect-data.json"']) if metadata_file: