github/datasette
1
0
Fork 0
mirror of https://github.com/simonw/datasette.git synced 2025-12-10 16:51:24 +01:00
Code Issues Projects Releases Packages Wiki Activity

Only load Python files from plugins-dir

Browse source 
Pull request #890. Thanks, @amjith!

* Load only python files from plugins-dir
* Add a test to verify non-python files are not loaded as plugins
This commit is contained in:
Amjith Ramanujam 2020-07-02 20:08:32 -07:00 • committed by GitHub
commit ea99a4431c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

4
tests/test_config_dir.py
View file

@ -30,6 +30,8 @@ def config_dir_client(tmp_path_factory):
plugins_dir = config_dir / "plugins"
plugins_dir.mkdir()
(plugins_dir / "hooray.py").write_text(PLUGIN, "utf-8")
(plugins_dir / "non_py_file.txt").write_text(PLUGIN, "utf-8")
(plugins_dir / ".mypy_cache").mkdir()
templates_dir = config_dir / "templates"
templates_dir.mkdir()
@ -95,6 +97,8 @@ def test_plugins(config_dir_client):
response = config_dir_client.get("/-/plugins.json")
assert 200 == response.status
assert "hooray.py" in {p["name"] for p in response.json}
assert "non_py_file.txt" not in {p["name"] for p in response.json}
assert "mypy_cache" not in {p["name"] for p in response.json}
def test_templates_and_plugin(config_dir_client):