github/datasette
1
0
Fork 0
mirror of https://github.com/simonw/datasette.git synced 2025-12-10 16:51:24 +01:00
Code Issues Projects Releases Packages Wiki Activity

/-/permissions?filter=exclude-yours/only-yours - closes #2460

Browse source
This commit is contained in:
Simon Willison 2025-02-04 11:09:44 -08:00
commit f57977a08f
3 changed files with 71 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

58
tests/test_permissions.py
View file

@ -371,12 +371,15 @@ def test_permissions_checked(app_client, path, permissions):
@pytest.mark.asyncio
async def test_permissions_debug(ds_client):
@pytest.mark.parametrize("filter_", ("all", "exclude-yours", "only-yours"))
async def test_permissions_debug(ds_client, filter_):
ds_client.ds._permission_checks.clear()
assert (await ds_client.get("/-/permissions")).status_code == 403
# With the cookie it should work
cookie = ds_client.actor_cookie({"id": "root"})
response = await ds_client.get("/-/permissions", cookies={"ds_actor": cookie})
response = await ds_client.get(
f"/-/permissions?filter={filter_}", cookies={"ds_actor": cookie}
)
assert response.status_code == 200
# Should have a select box listing permissions
for fragment in (
@ -398,17 +401,54 @@ async def test_permissions_debug(ds_client):
else bool(div.select(".check-result-true"))
),
"used_default": bool(div.select(".check-used-default")),
"actor": json.loads(
div.find(
"strong", string=lambda text: text and "Actor" in text
).parent.text.split(": ", 1)[1]
),
}
for div in check_divs
]
assert checks == [
{"action": "permissions-debug", "result": True, "used_default": False},
{"action": "view-instance", "result": None, "used_default": True},
{"action": "debug-menu", "result": False, "used_default": True},
{"action": "view-instance", "result": True, "used_default": True},
{"action": "permissions-debug", "result": False, "used_default": True},
{"action": "view-instance", "result": None, "used_default": True},
expected_checks = [
{
"action": "permissions-debug",
"result": True,
"used_default": False,
"actor": {"id": "root"},
},
{
"action": "view-instance",
"result": None,
"used_default": True,
"actor": {"id": "root"},
},
{"action": "debug-menu", "result": False, "used_default": True, "actor": None},
{
"action": "view-instance",
"result": True,
"used_default": True,
"actor": None,
},
{
"action": "permissions-debug",
"result": False,
"used_default": True,
"actor": None,
},
{
"action": "view-instance",
"result": None,
"used_default": True,
"actor": None,
},
]
if filter_ == "only-yours":
expected_checks = [
check for check in expected_checks if check["actor"] is not None
]
elif filter_ == "exclude-yours":
expected_checks = [check for check in expected_checks if check["actor"] is None]
assert checks == expected_checks
@pytest.mark.asyncio