New truncate_cells_html config for truncating cells, closes #330

This commit is contained in:
Simon Willison 2018-07-10 09:20:41 -07:00
commit fc9b1cc136
No known key found for this signature in database
GPG key ID: 17E2DEA2588B7F52
5 changed files with 54 additions and 0 deletions

View file

@ -974,6 +974,7 @@ def test_config_json(app_client):
"cache_size_kb": 0,
"allow_csv_stream": True,
"max_csv_mb": 100,
"truncate_cells_html": 2048,
} == response.json

View file

@ -69,6 +69,40 @@ def test_row_strange_table_name(app_client):
assert response.status == 200
def test_table_cell_truncation():
for client in app_client(config={
"truncate_cells_html": 5,
}):
response = client.get("/fixtures/facetable")
assert response.status == 200
table = Soup(response.body, "html.parser").find("table")
assert table["class"] == ["rows-and-columns"]
assert [
"Missi…", "Dogpa…", "SOMA", "Tende…", "Berna…", "Hayes…",
"Holly…", "Downt…", "Los F…", "Korea…", "Downt…", "Greek…",
"Corkt…", "Mexic…", "Arcad…"
] == [
td.string for td in table.findAll("td", {
"class": "col-neighborhood"
})
]
def test_row_page_does_not_truncate():
for client in app_client(config={
"truncate_cells_html": 5,
}):
response = client.get("/fixtures/facetable/1")
assert response.status == 200
table = Soup(response.body, "html.parser").find("table")
assert table["class"] == ["rows-and-columns"]
assert ["Mission"] == [
td.string for td in table.findAll("td", {
"class": "col-neighborhood"
})
]
def test_add_filter_redirects(app_client):
filter_args = urllib.parse.urlencode({
'_filter_column': 'content',