github/datasette
1
0
Fork 0
mirror of https://github.com/simonw/datasette.git synced 2025-12-10 16:51:24 +01:00
Code Issues Projects Releases Packages Wiki Activity

New _nocount=1 option, used to speed up CSVs - closes #1353

Browse source
This commit is contained in:
Simon Willison 2021-06-01 09:12:32 -07:00
commit fd368d3b2c
5 changed files with 34 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

9
tests/test_api.py
View file

@ -1683,6 +1683,15 @@ def test_nofacet(app_client, nofacet):
assert response.json["facet_results"] != {}
@pytest.mark.parametrize("nocount,expected_count", ((True, None), (False, 15)))
def test_nocount(app_client, nocount, expected_count):
path = "/fixtures/facetable.json"
if nocount:
path += "?_nocount=1"
response = app_client.get(path)
assert response.json["filtered_table_rows_count"] == expected_count
def test_expand_labels(app_client):
response = app_client.get(
"/fixtures/facetable.json?_shape=object&_labels=1&_size=2"

6
tests/test_csv.py
View file

@ -175,3 +175,9 @@ def test_table_csv_stream_does_not_calculate_facets(app_client):
response = app_client.get("/fixtures/simple_primary_key.csv?_trace=1")
soup = Soup(response.text, "html.parser")
assert "select content, count(*) as n" not in soup.find("pre").text
def test_table_csv_stream_does_not_calculate_counts(app_client):
response = app_client.get("/fixtures/simple_primary_key.csv?_trace=1")
soup = Soup(response.text, "html.parser")
assert "select count(*)" not in soup.find("pre").text